secp25k61: Polish field64 comments.#3713
Merged
Merged
Conversation
davecgh
force-pushed
the
secp256k1_field64_updates
branch
from
88b1dd4 to
14fd8ff
Compare
dajohi
approved these changes
Jul 1, 2026
jholdstock
reviewed
Jul 6, 2026
davecgh
force-pushed
the
secp256k1_field64_updates
branch
from
14fd8ff to
5e58c54
Compare
jholdstock
approved these changes
Jul 8, 2026
This moves some FieldVal64 methods around to match the order definition in the 10x26 field for consistency.
This adds a bunch of comments to the recently added FieldVal64 code and polishes some of the existing ones to make everything more consistent with the 10x26 field and provide mathematical justification for things such as bounds on the number of reductions and overflow prevention. While some of them are repetitive, it helps ensure they aren't lost if the old field implementation is ever removed in favor of the new field implementation. It also updates the 10x26 field rationale to account for modern Go additions and the new field.
davecgh
force-pushed
the
secp256k1_field64_updates
branch
from
5e58c54 to
e017347
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires #3712.This adds a bunch of comments to the recently added
FieldVal64code and polishes some of the existing ones to make everything more consistent with the 10x26 field and provide mathematical justification for things such as bounds on the number of reductions and overflow prevention.While some of them are repetitive, it helps ensure they aren't lost if the old field implementation is ever removed in favor of the new field implementation.
It also updates the 10x26 field rationale to account for modern Go additions and the new field.
Finally, it reorders a some of the
FieldVal64methods around to match the order definition in the 10x26 field for consistency.